chore(toolkit): enforce all imports from aws-cdk are via one file #33145
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33145 +/- ##
=======================================
Coverage 81.57% 81.57%
=======================================
Files 227 227
Lines 13793 13793
Branches 2419 2419
=======================================
Hits 11251 11251
Misses 2270 2270
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
mrgrain
added
the
pr-linter/cli-integ-tested
|
Bypassing mergify because this is a complex PR that needs to get in asap |
mrgrain
deleted the
mrgrain/chore/toolkit/enforce-imports-from-aws-cdk
branch
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
We bundle
aws-cdkinto that file and if we don't load everything through it, imports will fail.Description of changes
Fix the wrong import and add a linter rule to enforce it.
Describe any new or updated permissions being added
n/a
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license